#259 support more currencies #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrency_code to ticket_category and additional_service through a view
syjer
approved these changes
Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have adopted a more pragmatic approach (as opposed to the previous attempt, https://github.com/alfio-event/alf.io/compare/%23259-currency-decimal-places ) and therefore I have modified the minimum amount of classes in order to reach the goal.
I think that this approach allows us to include the modification in the upcoming M2 release, since it does not require that much effort in order to be tested.
After merging the PR, I will do a thorough test with Stripe and PayPal on our test instance. After that, I'll modify #259