Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency missing #259

Closed
sibivs opened this issue Feb 14, 2017 · 8 comments
Closed

Currency missing #259

sibivs opened this issue Feb 14, 2017 · 8 comments
Labels
prio: 3
Milestone
2.0-M2

Comments

@sibivs
Copy link

sibivs commented Feb 14, 2017

Dear Team,

I am Varghese, from Bahrain. I was trying the Alf.io system on Heroku. I am able to set it up, integrate with google geo location etc. But i cannot find the BHD currency under the "Seats and payment info".
Please let me know how to add the missing currency
@cbellone
Copy link
Member

Hi Varghese,

thanks for your interest in alf.io!!

At the moment we support only currencies with two decimal places. As far as I know, BHD uses three decimal places, right?

I think that we could add support for your currency in the next release (1.11). Could you help us with the testing?

Celestino

@sibivs
Copy link
Author

sibivs commented Feb 14, 2017

Dear Celestino,

Thanks for the response.
For sure its my pleasure to test it.

--
Varghese

@cbellone cbellone modified the milestones: BackLog, 1.11 Apr 11, 2017
@cbellone cbellone added this to TODO in 1.11 Apr 11, 2017
@syjer
Copy link
Member

syjer commented Apr 21, 2017

will switch from our custom implementation to http://javamoney.github.io/ri.html . This will largely improve our current situation :D

@cbellone cbellone modified the milestones: 1.11, 1.12 Jun 1, 2017
@syjer syjer removed this from TODO in 1.11 Jun 19, 2017
@syjer syjer added this to TODO in 1.12 Jun 19, 2017
@cbellone cbellone removed this from TODO in 1.12 Sep 6, 2017
@cbellone cbellone modified the milestones: 1.12, 1.13 Sep 6, 2017
@syjer syjer added this to TODO in 1.13 Sep 8, 2017
@syjer syjer removed this from the 1.13 milestone Dec 2, 2017
@syjer syjer removed this from TODO in 1.13 Dec 2, 2017
@kazarrugh
Copy link

Hello,
I installed Alf.io on my server, but I can't find my local currency 'LYD'
Is there a way to add it in any of the tables in postgres? Thanks.

@syjer
Copy link
Member

syjer commented Apr 27, 2019

hi @kazarrugh , currently we don't support some currencies due to some assumptions in the code. We will fix this issue in the 2.0 release (by switching to https://www.joda.org/joda-money/ ).

Sorry for the inconvenience.

@syjer syjer modified the milestones: 2.0, 2.0-M2 Apr 27, 2019
@syjer syjer removed their assignment May 4, 2019
cbellone added a commit that referenced this issue May 14, 2019
@cbellone
#259 - step 1: introduce joda-money and refactor existing code
e175fb9
@kazarrugh
Copy link

Hello @syjer, thanks for your feedback. Please let me know when it will be added so that I can test it. Thanks a lot!

cbellone added a commit that referenced this issue Jun 30, 2019
@cbellone
Merge branch 'master' into #259-support-more-currencies
123268e
@cbellone cbellone mentioned this issue Jun 30, 2019
Merged
cbellone added a commit that referenced this issue Jul 3, 2019
@cbellone
#259 support more currencies (#673)
c851a9f 
* add currency_code column to ticket and additional_service_item. Add currency_code to ticket_category and additional_service through a view

* add joda-money, add support for all currencies excluding pseudo-currencies

* use the right format on the UI
@cbellone
Copy link
Member

cbellone commented Jul 3, 2019

This should be fixed now on master.
@sibivs, @kazarrugh : It would be great if you could test it. If you need access to our test platform please let me know.

Thanks for your patience and your help! :)

@cbellone
Copy link
Member

image

I guess we can consider it implemented :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: 3
Projects
None yet
Milestone
2.0-M2
Development

No branches or pull requests
4 participants
@syjer @cbellone @kazarrugh @sibivs