Revert #461 and add a regression test for what it broke. #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where STUN binding messages that would have been buffered prior to receiving an answer were instead dropped
algesten
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the bug mentioned in #461 was real as of version
0.4.1, it had since been fixed by #418, rendering my fix redundant.My fix also caused a regression - STUN binding requests received before remote credentials were set were being dropped by
IceAgent.accept_message(), instead of being let through and subsequently buffered viaIceAgent.stun_server_queue.Rather than just revert the PR, this also adds a test to catch further regressions of this buffering.