Fix panic in Rtc::accepts() with STUN traffic #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for another instance, when the first instance has not negotiated
OxleyS
added a commit
to OxleyS/str0m
that referenced
this pull request
Mar 19, 2024
This fixes a bug where STUN binding messages that would have been buffered prior to receiving an answer were instead dropped
algesten
pushed a commit
that referenced
this pull request
Mar 19, 2024
This fixes a bug where STUN binding messages that would have been buffered prior to receiving an answer were instead dropped
thomaseizinger
pushed a commit
to thomaseizinger/str0m
that referenced
this pull request
Mar 21, 2024
This fixes a bug where STUN binding messages that would have been buffered prior to receiving an answer were instead dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
As a summary of that discussion, if you have two
Rtcinstances, one negotiated and the other not, and you pass incoming STUN traffic intended for the negotiated instance to theRtc::accepts()of the non-negotiated instance, it will panic instun_credentialsbecause without an offer, no remote ICE credentials will have been sent. This PR simply checks for this case first.