Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune some logging levels #510

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

xnorpx
Copy link
Collaborator

@xnorpx xnorpx commented Apr 30, 2024

To reduce the chattiness on debug move some packet level logging to trace.

@algesten
Copy link
Owner

@thomaseizinger @davibe @k0nserv in case you want to check whether these proposed log changes would negatively affect you.

@k0nserv
Copy link
Collaborator

k0nserv commented Apr 30, 2024

Fine by me!

Copy link
Collaborator

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but overall, this follows a convention that we've been following in our codebase: Anything that happens per packet is on trace.

src/ice/agent.rs Show resolved Hide resolved
@xnorpx
Copy link
Collaborator Author

xnorpx commented May 1, 2024

@algesten can this be merged?

@algesten
Copy link
Owner

algesten commented May 1, 2024

Let's do this

@algesten algesten merged commit c5c04a3 into algesten:main May 1, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants