fix: use reader for bytes http response transformation #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The From implementation to transform a ureq::Response into an http::Response<Vec<u8>> is using the into_string() method. This method only allows for UTF-8 characters in the body payload, thus the result is inconsistent for non UTF-8 characters like protobuffers (binary). The proposed solution uses the reader instead of transforming the input into a UTF-8 character.
|
Thanks! I will get my head around this soon. Currently I'm blocked on trying to fix: #688 |
|
Hi @algesten, any update on this small fix? Thank you! |
algesten
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The From implementation to transform a ureq::Response into an http::Response<Vec> is using the into_string() method. This method only allows for UTF-8 characters in the body payload, thus the result is inconsistent for non UTF-8 characters like protobuffers (binary).
The proposed solution uses the reader instead of transforming the input into a UTF-8 character.