Handle intents without a query slot (#19)

* Handle intents without a query slot * Handle cases where there are no intents
algolia · Aug 23, 2017 · 5e09a1c · 5e09a1c
1 parent 3141e1e
commit 5e09a1c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/utils/build_handlers.js b/src/utils/build_handlers.js
@@ -21,8 +21,13 @@ function buildFromObject(obj, index, stateString) {
       object[key] = function() {
         const args = {event: this.event};
         const params = buildParams(paramsObj, this.event);
+        let query = '';
+        if (args.event.request.intent.slots && args.event.request.intent.slots.query) {
+          query = args.event.request.intent.slots.query.value;
+        }
+
         index
-          .search(args.event.request.intent.slots.query.value, params)
+          .search(query, params)
           .then((results, err) => {
             Object.assign(args, {err, results});
             func.call(this, args);

diff --git a/test/utils/build_handlers.test.js b/test/utils/build_handlers.test.js
@@ -84,10 +84,19 @@ describe('handlers', () => {
 
       describe('with answerWith', () => {
         describe('without params to merge', () => {
+          const expectedParams = {};
+
+          describe('without a query slot', () => {
+            const withoutQuery = JSON.parse(JSON.stringify(scope));
+            delete withoutQuery.event.request.intent.slots;
+
+            builtHandlers[0].spyIntent.call(withoutQuery);
+
+            expect(searchSpy).toHaveBeenCalledWith('', expectedParams);
+          });
+
           describe('when handler is invoked', () => {
             it('searches Algolia', () => {
-              const expectedParams = {};
-
               builtHandlers[0].spyIntent.call(scope);
 
               expect(searchSpy).toHaveBeenCalledWith(expectedQuery, expectedParams);