Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: composableFilterOption deserialization fixed #717

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

mehmetaligok
Copy link
Contributor

@mehmetaligok mehmetaligok commented Feb 16, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Need Doc update no

Describe your change

composableFilterOption deserialization fixed to handle mixed cases. Also, deserialization logic is fixed to take the first level as separate and group. With the changes deserialization handles the following cases;

["color:green","color:yellow"] => [["color:green"],["color:yellow"]]

[["color:green","color:yellow"], "color:blue"] => [["color:green","color:yellow"], ["color:blue"]]

Other client library PRs that fix related issues are based. Ex: algolia/algoliasearch-client-java#771


PS: When fixing this issue, we noticed that legacy one string parsing is also not handled properly in this client. It will be addressed with another PR.

@mehmetaligok mehmetaligok marked this pull request as ready for review February 16, 2023 10:12
@mehmetaligok mehmetaligok self-assigned this Feb 16, 2023
Copy link
Contributor

@sbellone sbellone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for tackling it!

algolia/opt/composable_filter.go Show resolved Hide resolved
@mehmetaligok mehmetaligok merged commit b3a3422 into master Feb 16, 2023
@mehmetaligok mehmetaligok deleted the fix/compasable-filter-deserialization-fixed branch February 16, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants