-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to initialize SearchClient on Python 3.11 #549
Comments
hey it indeed support up to python 3.9, there was this community PR opened but it got closed: #548 feel free to re-open I'll make sure to review! |
i do have the same problem as well @shortcuts :) If you could review and update the library that would be awesome ! |
Hey folks, my attempt on fixing the issue in this pull request: #551 |
Thanks for the PR @salomvary ! I'm also interested in having support for 3.11. |
Is there any news on this ticket? We're blocked from upgrading our application to Python 3.11 until it's ready. |
Hello, just wanted to add another voice that we are also interested in having this fixed. Please let me know if there is some way I can help! |
Hey, I'm back from holidays and just added #553 to my sprint, will try to release before tomorrow. Sorry for the wait everyone! edit: took a bit longer than expected, looking to fix the issues |
| Q | A | ----------------- | ---------- | Bug fix? | yes | New feature? | no <!-- please update the /CHANGELOG.md file --> | BC breaks? | no | Related Issue | Fix #549, Fix #551 | Need Doc update | yes ## Describe your change This PR removes support for python 2.7, adds support for python 3.11 and tests the project against 3.9, 3.10, and 3.11: - Replaced all @asyncio.coroutine decorators by async def function def - Replaced `yield from` with `await` or `return` statements - Added python 3.9, 3.10, and 3.11 to tox and circleci ## What problem is this fixing? Due to a removed syntax in python 3.11, the package was not working. --------- Co-authored-by: shortcuts <vannicattec@gmail.com>
doing some cleanup etc. and will release the new major |
Description
When trying to initialize the
SearchClient
on Python 3.11 (withaiohttp
installed to enable async requests), the following exception occurs:It seems like it's related to the deprecation of the
@asyncio.coroutine
decorator, as described here: https://docs.python.org/3.10/library/asyncio-task.html#asyncio.coroutineSteps To Reproduce
Install the python 3.11 interpreter, or use a python 3.11 docker image (I used this command to test the issue
$ docker run --rm -it python:3.11 bash
Then install
algoliaclient
andaiohttp
And the run the following in a python shell:
The text was updated successfully, but these errors were encountered: