Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Python 3.9, 3.10 and 3.11 #553

Merged
merged 16 commits into from
Feb 24, 2023

Conversation

paul-finary
Copy link
Contributor

@paul-finary paul-finary commented Jan 10, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #549, Fix #551
Need Doc update yes

Describe your change

This PR removes support for python 2.7, adds support for python 3.11 and tests the project against 3.9, 3.10, and 3.11:

  • Replaced all @asyncio.coroutine decorators by async def function def
  • Replaced yield from with await or return statements
  • Added python 3.9, 3.10, and 3.11 to tox and circleci

What problem is this fixing?

Due to a removed syntax in python 3.11, the package was not working.

@paul-finary
Copy link
Contributor Author

Hi @shortcuts , I opened this PR because the other one (#551) is stale for 3 weeks now. However the tests are failing on circleci even though they're all passing locally. Do you have any idea ?

@paul-finary
Copy link
Contributor Author

paul-finary commented Jan 18, 2023

Hi @shortcuts,
Sorry to insist, but did you have a look at this PR ?

@paul-finary
Copy link
Contributor Author

paul-finary commented Jan 31, 2023

Hi again,

Can someone look at this PR ?

@shortcuts
Copy link
Member

hey, checking right now for the CI! thanks for the contribution :)

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! small comment

still trying to figure out the CI issue, not sure if it's related to the fork 🤔

.circleci/config.yml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@shortcuts shortcuts changed the title Chore/python 3 11 feat: add support for Python 3.9, 3.10 and 3.11 Feb 1, 2023
@paul-finary
Copy link
Contributor Author

looks great! small comment

Hi, I fixed both comments :)

@paul-finary
Copy link
Contributor Author

Hi, there' still issues with the pipelines even thought the tests are running locally, do you have an idea on how to solve it ?

.circleci/config.yml Outdated Show resolved Hide resolved
@shortcuts
Copy link
Member

hey @paul-finary, fixed the CI so it should now properly run and report errors, let me know if you still have time to work on that

@shortcuts
Copy link
Member

fixed some more again, should be more reliable now, still some flaky ones but there seems to be errors related to yield inside async fns

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like everything is covered, I'll do an other pass and plan the release ASAP

@shortcuts shortcuts merged commit 2d4a7e2 into algolia:master Feb 24, 2023
@paul-finary paul-finary deleted the chore/python_3_11 branch October 9, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to initialize SearchClient on Python 3.11
3 participants