-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deleting by query #92
Comments
tldr; For now we won't support the delete by query in the scala client. Longer: The issue is that One possible solution would be to use an For now, we don't think it's a good solution. Maybe you have an idea on how to implement that? |
We use Scalaz (v. 7.1.7, by the way), so that wouldn't be problematic for us, although it might be tricky to manage if there's some Scalaz version incompatibility down the road. Would it be possible for you to change your REST API to support delete by query? If so, it would be trivial to implement in any client. :) |
Nice to hear people using Scalaz :) As for the REST API, it's currently not in our roadmap, as every API client has it (but scala). |
I don't have a better idea for implementation, but it seems that a synchronous implementation would be better than no implementation at all. Otherwise the consumers will be implementing the same sort of API independently, and you'll have little control over making improvements to their implementation. |
Ok, we'll implement a synchronous deleteByQuery |
Update README Scala [This list might not be relevant] Typo (algolia#92) [ci skip]
The Scala client currently only supports deleting by
objectId
. It would be useful to delete by query, similar to what's supported in the Ruby client (https://www.algolia.com/doc/ruby#delete-by-query). In our case, ourobjectId
is structured enough that we could also match a pattern/regex against theobjectId
field, but querying against fields in our search documents would work quite well, too.The text was updated successfully, but these errors were encountered: