Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

isRefined is not checking if the attribute has a numeric refinement #110

Closed
redox opened this issue Jun 18, 2015 · 4 comments
Closed

isRefined is not checking if the attribute has a numeric refinement #110

redox opened this issue Jun 18, 2015 · 4 comments
Assignees
Milestone

Comments

@redox
Copy link
Contributor

redox commented Jun 18, 2015

isRefined is checking if it a facet or disjunctive facet has a refinement; we should also check it it's an attribute with a numerical refinement.

@bobylito
Copy link
Contributor

Well I think hasRefinement would be a better candidate to get if an attribute has any kind of numeric refinement. isRefined has more parameters which are not consistent between facets and numeric filters.

@redox
Copy link
Contributor Author

redox commented Jun 23, 2015

@bobylito
Copy link
Contributor

@redox what do you mean?

@redox
Copy link
Contributor Author

redox commented Jun 23, 2015

Sorry, I meant currently isRefined <=> hasRefinements that's why I was thinking it should handle it.

@bobylito bobylito self-assigned this Jun 23, 2015
@bobylito bobylito added this to the 2.1.2 milestone Jun 24, 2015
bobylito added a commit that referenced this issue Jun 26, 2015
FIX #110 : provide a way to test if an attribute is numerically defined
bobylito pushed a commit that referenced this issue Jun 29, 2015
  * FIX : #113 support for attributes hightlightPreTag and hightlighPostTag
  * FIX : #112 distinct = undefined sent to the server
  * FIX : #110 helper.hasRefinements() now checks for numerics
  * FIX : #106 convert refinements to string
  * DOC : Update theme + fix (github.com/algolia/minami)
  * DOC : Fix misc links and descrition and added samples of objects
  * DOC : Added a cheat sheet in the generated documentation
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
…ix/110

FIX algolia/algoliasearch-helper-js#110 : provide a way to test if an attribute is numerically defined
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
  * FIX : algolia/algoliasearch-helper-js#113 support for attributes hightlightPreTag and hightlighPostTag
  * FIX : algolia/algoliasearch-helper-js#112 distinct = undefined sent to the server
  * FIX : algolia/algoliasearch-helper-js#110 helper.hasRefinements() now checks for numerics
  * FIX : algolia/algoliasearch-helper-js#106 convert refinements to string
  * DOC : Update theme + fix (github.com/algolia/minami)
  * DOC : Fix misc links and descrition and added samples of objects
  * DOC : Added a cheat sheet in the generated documentation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants