Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autocomplete frontend hook #641

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Fix autocomplete frontend hook #641

merged 1 commit into from
Jan 14, 2019

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Dec 18, 2018 •
edited
Loading

Fix the beforeAutocompleteSources frontend hook for autocomplete (allows to complete the tutorial How to add external autocomplete source )

@damcou damcou requested a review from JanPetr December 18, 2018 13:56
@TravisBuddy
Copy link

Hey @damcou,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 1f88dde0-02cf-11e9-819e-e174a5d00ea5

JanPetr
JanPetr approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@JanPetr JanPetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanPetr JanPetr changed the base branch from master to develop January 14, 2019 17:37
@JanPetr JanPetr merged commit b6a5de3 into develop Jan 14, 2019
@JanPetr JanPetr deleted the fix-frontend-hook branch January 14, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanPetr JanPetr JanPetr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damcou @TravisBuddy @JanPetr