Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing page builder feature #661

Merged
merged 81 commits into from Feb 15, 2019
Merged

Landing page builder feature #661

merged 81 commits into from Feb 15, 2019

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Jan 23, 2019

No description provided.

@damcou
Adding Router
13f106d
@damcou
Add Landing Page Entity
329034a
@damcou
Add Landing Page CRUD
c918c52
@damcou
customize form
2b94842
@damcou
Make form compatible with Magento 2.1
ca00e66
@damcou
Add form buttons
98fc7a8
@damcou
Add router and controller to display the landing page on frontend
09f83a7
@damcou
Add frontend display
359a845
@damcou
Add date check
59ce091
@damcou
Add search confguration widget in the form
cf67904
@damcou
Add instantsearch in the landing page configuration
ae79cf9
@damcou
Add search configuration and query rule deletion/creation
af0a232
@damcou
Add categories and prices filters
7eaaa61
@damcou
Udpate css
81e6e76
@damcou
Add url rewrite management
0773a34
@damcou
Handling store switch
2c6ffa9
@damcou
Add some form customization
c9678ca
@damcou
Add View feature and listing columns
a3c7ae2
@damcou
Add suggestions header on listing
5b71ee2
@damcou
Add duplication feature + query rules management
88d9cc8
@damcou
Put "From" and "To" timeframe on the same line
538ab9f
@damcou
Add ajax check on url_key input
8203a34
@damcou
Design customization
e33298d
@damcou
Add custom_css and custom_js fields
06c62ba
@damcou
Enhance form display
6ec1016
@damcou
Add the possibility to add products on a no-results query
f6f1b1d
@damcou
Code Style
a960916
@damcou
Add plan limitations
189c4b8
@damcou
Add API call to get the plan level
db75929
@damcou
Fixes
eab5bbd
@damcou
Fixes
b6add7f
@damcou
Make the form compatible with Magento 2.1
f2e1851
@damcou
replace spaces by tabs
961cf53
@damcou
Merge with develop
1181664
@damcou
Merge remote-tracking branch 'origin/feat-landing-page-builder' into …
7422778 
…feat-landing-page-builder

# Conflicts:
#	Block/Algolia.php
#	view/adminhtml/templates/adminjs.phtml
#	view/adminhtml/templates/analytics/overview.phtml
AlexEven
AlexEven reviewed Feb 4, 2019
View reviewed changes
Copy link

@AlexEven AlexEven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some changes to the wording we've seen with Lucia + some questions that we can discuss if available.
Let us know if you have any questions.
Thank you!

view/adminhtml/ui_component/algolia_algoliasearch_landingpage_form.xml Outdated Show resolved Hide resolved
view/adminhtml/ui_component/algolia_algoliasearch_landingpage_form.xml Outdated Show resolved Hide resolved
view/adminhtml/ui_component/algolia_algoliasearch_landingpage_form.xml Outdated Show resolved Hide resolved
view/adminhtml/ui_component/algolia_algoliasearch_landingpage_form.xml Outdated Show resolved Hide resolved
view/adminhtml/ui_component/algolia_algoliasearch_landingpage_form.xml Outdated Show resolved Hide resolved
view/adminhtml/ui_component/algolia_algoliasearch_landingpage_form.xml Outdated Show resolved Hide resolved
view/adminhtml/ui_component/algolia_algoliasearch_landingpage_form.xml Outdated Show resolved Hide resolved
view/adminhtml/ui_component/algolia_algoliasearch_landingpage_form.xml Outdated Show resolved Hide resolved
view/adminhtml/ui_component/algolia_algoliasearch_landingpage_form.xml Outdated Show resolved Hide resolved
view/adminhtml/ui_component/algolia_algoliasearch_landingpage_form.xml Show resolved Hide resolved
@TravisBuddy
Copy link

Hey @damcou,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 62b16d90-2e2a-11e9-93d2-519d0ef52680

@algolia algolia deleted a comment from TravisBuddy Feb 12, 2019
JanPetr
JanPetr approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@JanPetr JanPetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The PR is huge, I probably didn't get all the details.
I noticed only 2 things I wanted to ask, so I added questions. Otherwise it looks good :)

Good job, @damcou 🙌

Controller/Adminhtml/Landingpage/Delete.php
/** @var \Algolia\AlgoliaSearch\Model\LandingPage $landingPage */
$landingPage = $this->landingPageFactory->create();
$landingPage->getResource()->load($landingPage, $landingPageId);
$landingPage->getResource()->delete($landingPage);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL is deleted automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I added a _afterDelete() method on the resource model : https://github.com/algolia/algoliasearch-magento-2/blob/feat-landing-page-builder/Model/ResourceModel/LandingPage.php#L79

Controller/Adminhtml/Landingpage/Index.php
$resultPage->getConfig()->getTitle()->prepend($breadMain);

$dataPersistor = $this->_objectManager->get(\Magento\Framework\App\Request\DataPersistorInterface::class);
$dataPersistor->clear('landing_page');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is data persistor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's used to keep the submitted data when needed : https://github.com/algolia/algoliasearch-magento-2/blob/feat-landing-page-builder/Controller/Adminhtml/Landingpage/Save.php#L119.
I took inspiration from the M2 CMS page feature for this : https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Cms/Controller/Adminhtml/Page/Index.php#L56

@TravisBuddy
Copy link

Hey @damcou,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: b45fc0d0-3111-11e9-91d5-11294258c2e5

@damcou damcou merged commit 11969d4 into develop Feb 15, 2019
@JanPetr JanPetr deleted the feat-landing-page-builder branch March 6, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexEven AlexEven AlexEven left review comments

@JanPetr JanPetr JanPetr approved these changes

@bsuravech bsuravech Awaiting requested review from bsuravech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@damcou @TravisBuddy @JanPetr @AlexEven