Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Indexing Queue Feature #1070

Merged
merged 12 commits into from
Nov 28, 2018
Merged

Admin Indexing Queue Feature #1070

merged 12 commits into from
Nov 28, 2018

Conversation

bsuravech
Copy link
Contributor

Summary
Backport the M2 feature for Indexing Queue feature in admin. Changes to match:

algolia/algoliasearch-magento-2#537

Result

  • Updated version to 1.15.0 for table setup
  • Adding new admin menu item for Indexing Queue in System > Algolia Search
  • ACL has been added for Indexing Queue
  • Indexing Queue grid calling job collection
  • Indexing Queue job view is a readonly form
  • Added algoliasearch_queue_archive table and added updated error_logging for queue job processing
  • Added clearQueue() method to Algolia_Algoliasearch_Model_Queue and updated controller actions truncating queue table

@bsuravech bsuravech requested a review from damcou October 24, 2018 20:35
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job @bsuravech !
Just a few things to add but globally the feature is perfectly redone ;)

Copy link
Contributor

@JanPetr JanPetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @bsuravech 💯

Just 2 things:

  • Can the default sort by by date or ID ASC? I think a customers would like to see jobs which will be processed first first :))

screenshot 2018-11-05 14 10 46

  • Question added to clearQueue() method :)

Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me now ;)

@bsuravech bsuravech merged commit 02fe02d into develop Nov 28, 2018
@JanPetr JanPetr deleted the admin-indexing-queue branch February 14, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants