Feat/angular 13 - work in progress... #1006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seem to be no required changes for Angular 13 to build, as you can see in https://github.com/Haroenv/angular-instantsearch-angular-13 I did not update the build dependencies to Angular 13, as it required some more changes that we can do later, the current version is usable as-is in angular 5 (possibly only from 8) - 14 fixes algolia#885
Co-authored-by: Haroen Viaene <hello@haroen.me>
…e-snippet>` components (algolia#891)
Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…algolia#962) * feat(search-box): add loading indicator and `showLoadingIndicator` prop to show/hide it * feat(search-box): always show reset button when showLoadingIndicator is false
* chore: update `instantsearch.js` * Update package.json * update lockfile * latest patch * update again Co-authored-by: Haroen Viaene <fingebimus@me.com> Co-authored-by: Haroen Viaene <hello@haroen.me>
Co-authored-by: Haroen Viaene <hello@haroen.me>
* fix: use pages property of state in pagination.ts * fix: forgot to add padding to connector options * fix: padding default value is determined by connector * fix: adjusted tests for the new pages property
Co-authored-by: Haroen Viaene <hello@haroen.me>
Co-authored-by: Kármán Zsombor <karman.zsombor@basecloud.hu>
Co-authored-by: Haroen Viaene <hello@haroen.me>
we aren't merging the PRs, so it's only noise
* chore: release v4.4.1 * edit changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please note - this is a WIP commit/PR, some guidelines would be helpful to move forward. The aim is to upgrade to Angular 16/17, since the current release can not be used in Angular applications using v16 or better.
I've upgraded the e-commerce example and instantsearch to Angular 13.4.0, but there is a stumbling block.
The build for succeeds, but since ng-packagr 13.x no longer supports umdModuleId the following output is not being written to dist/bundles:
angular-instantsearch.umd.js
angular-instantsearch.umd.js.map
instantsearch.css
instantsearch.min.css
instantsearch-theme-algolia.css
instantsearch-theme-algolia.min.css
Result
➜ yarn examples:ecommerce
yarn run v1.22.19
$ ./scripts/run-example.sh e-commerce
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
success Already up-to-date.
$ ./scripts/build.sh
Building Angular Package
WARNING: Project is attempting to disable the Ivy compiler. Angular versions 13 and higher do not support View Engine compiler for libraries. The Ivy compiler will be used to build this project.
For additional information or if the build fails, please see https://v12.angular.io/guide/ivy
Building entry point 'angular-instantsearch'
✔ Compiling with Angular sources in Ivy partial compilation mode.
✔ Writing FESM bundles
✔ Copying assets
ℹ Removing scripts section in package.json as it's considered a potential security vulnerability.
ℹ Removing devDependencies section in package.json.
ℹ Removing jest section in package.json.
✔ Writing package manifest
✔ Built angular-instantsearch
Built Angular Package
Build at: 2023-12-12T14:04:40.200Z - Time: 6411ms
cp: target 'dist/bundles' is not a directory
error Command failed with exit code 1.