Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): revenue and filterEffects typing updates #2105

Merged
merged 3 commits into from
Oct 12, 2023
Merged

feat(specs): revenue and filterEffects typing updates #2105

merged 3 commits into from
Oct 12, 2023

Conversation

cdhawke
Copy link
Contributor

@cdhawke cdhawke commented Oct 10, 2023 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: OPTIM-748

Changes included:

  • Fix endAt typing on ABTest
  • Add Revenue typing for purchase, addToCart, and revenue significance, as well as metrics for currencies
  • Add filterEffects to display outlier data, taking the place of outlier...Count properties
  • Add configuration on abtest creation post and retrieval get and list

🧪 Test

Green CI

@cdhawke cdhawke self-assigned this Oct 10, 2023
@cdhawke cdhawke requested a review from a team as a code owner October 10, 2023 15:46
@cdhawke cdhawke requested review from damcou and Fluf22 October 10, 2023 15:46
@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 604d7c7
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6527a19374839c0008cda6fd
😎 Deploy Preview https://deploy-preview-2105--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 10, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@cdhawke cdhawke changed the title feat(abtests): Revenue and filterEffects typing updates feat(specs): revenue and filterEffects typing updates Oct 10, 2023
shortcuts
shortcuts reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

specs/abtesting/common/schemas/ABTest.yml Show resolved Hide resolved
JonathanMontane
JonathanMontane reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@JonathanMontane JonathanMontane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the spec side as far as I can tell!

shortcuts
shortcuts approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shortcuts shortcuts merged commit b5ec541 into main Oct 12, 2023
21 checks passed
@shortcuts shortcuts deleted the feat/abtests/add-revenue-and-filter-effects branch October 12, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanMontane JonathanMontane JonathanMontane left review comments

@shortcuts shortcuts shortcuts approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

@febeck febeck Awaiting requested review from febeck

Assignees

@cdhawke cdhawke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cdhawke @algolia-bot @JonathanMontane @shortcuts