Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(javascript): algoliaseach bundling #2185

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix(javascript): algoliaseach bundling #2185

merged 1 commit into from
Oct 26, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 26, 2023

🧭 What and Why

While trying to upgrade node I noticed that the playground and algoliasearch was broken, thanks @shortcuts for the help

@millotp millotp self-assigned this Oct 26, 2023
@millotp millotp requested a review from a team as a code owner October 26, 2023 13:05
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 26, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gggggg much cleaner!

@netlify
Copy link

netlify bot commented Oct 26, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 468231c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/653a63feb4049500080f0e15
😎 Deploy Preview https://deploy-preview-2185--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@millotp millotp merged commit 6fa5a40 into main Oct 26, 2023
23 checks passed
@millotp millotp deleted the fix/algoliasearch branch October 26, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@millotp @algolia-bot @shortcuts