Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): algoliaseach bundling #2185

Merged
merged 1 commit into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/.cache_version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.0.98
0.0.99
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ ENV DOCKER=true
# use bash for subsequent commands
SHELL ["/bin/bash", "--login", "-c"]

# Global
# Global (python3 is needed by npm to build parcel on some platforms)
RUN apt-get update && apt-get install -y --no-install-recommends \
curl zip unzip git openssh-server \
curl zip unzip git openssh-server python3 \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"files": [
{
"path": "packages/algoliasearch/dist/algoliasearch.umd.js",
"maxSize": "8.55KB"
"maxSize": "8.10KB"
},
{
"path": "packages/algoliasearch/dist/lite/lite.umd.js",
Expand Down Expand Up @@ -34,7 +34,7 @@
},
{
"path": "packages/ingestion/dist/ingestion.umd.js",
"maxSize": "4.95KB"
"maxSize": "5.05KB"
},
{
"path": "packages/monitoring/dist/monitoring.umd.js",
Expand Down
1 change: 1 addition & 0 deletions playground/javascript/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "javascript-playground",
"version": "0.0.0",
"private": true,
"type": "module",
"scripts": {
"start:algoliasearch": "ts-node algoliasearch.ts",
"start:abtesting": "ts-node abtesting.ts",
Expand Down
9 changes: 8 additions & 1 deletion playground/javascript/node/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
{
"extends": "../../../config/base.tsconfig.json",
"compilerOptions": {
"module": "esnext",
"target": "esnext",
"outDir": "dist"
},
"include": ["*.ts"]
"ts-node": {
"esm": true
},
"include": [
"*.ts"
]
}
2 changes: 1 addition & 1 deletion templates/javascript/clients/index.d.mustache
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// eslint-disable-next-line import/no-unresolved
export * from './dist/builds/node';
export * from './dist/{{#isAlgoliasearchClient}}algoliasearch/{{/isAlgoliasearchClient}}builds/node';
6 changes: 0 additions & 6 deletions templates/javascript/clients/tsconfig.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
{{/isAlgoliasearchClient}}
"outDir": "dist"
},
{{#isAlgoliasearchClient}}
"include": ["*.ts"],
"exclude": ["dist", "node_modules", "__tests__", "lite"]
{{/isAlgoliasearchClient}}
{{^isAlgoliasearchClient}}
"include": ["{{apiPackage}}", "model", "builds"],
"exclude": ["dist", "node_modules"]
{{/isAlgoliasearchClient}}
}