Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): rename clearAllSynonyms to clearSynonyms #2553

Merged
merged 2 commits into from
Jan 16, 2024
Merged

fix(specs): rename clearAllSynonyms to clearSynonyms #2553

merged 2 commits into from
Jan 16, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Jan 16, 2024 •
edited
Loading

🧭 What and Why

To be consistent with clearObjects() and clearRules() methods, rename this method to clearSynonyms().

🎟 JIRA Ticket: N/A (Slack)

Changes included:

  • Rename filename and operationId

@netlify Netlify
Copy link

netlify bot commented Jan 16, 2024 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 89676dc
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65a6c6f095a7ae0008d76ed5
😎 Deploy Preview https://deploy-preview-2553--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 16, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! you also need to rename the test file of the same name

@kai687 kai687 changed the title fix: rename clearAllSynonyms to clearSynonyms fix(specs): rename clearAllSynonyms to clearSynonyms Jan 16, 2024
@kai687 kai687 marked this pull request as ready for review January 16, 2024 18:34
@kai687 kai687 requested a review from a team as a code owner January 16, 2024 18:34
shortcuts
shortcuts approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! thanks

@shortcuts shortcuts merged commit 8b06223 into main Jan 16, 2024
29 checks passed
@shortcuts shortcuts deleted the fix/clear-synonyms branch January 16, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kai687 @algolia-bot @shortcuts