Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clients): chunked batch helper size property consistency #3253

Merged
merged 5 commits into from
Jun 25, 2024
Merged

fix(clients): chunked batch helper size property consistency #3253

merged 5 commits into from
Jun 25, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jun 25, 2024

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

  • use batchSize value for slice memory allocation (go)
  • add chunkedBatch derivatives with default values (java)

@Fluf22 Fluf22 requested a review from a team as a code owner June 25, 2024 15:01
@Fluf22 Fluf22 self-assigned this Jun 25, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 25, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great CATCH

@Fluf22 Fluf22 enabled auto-merge (squash) June 25, 2024 15:05
shortcuts
shortcuts approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

🚀 Deployed on https://667ae8c63ba8772985774053--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 25, 2024 15:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 25, 2024 15:56 Inactive
@Fluf22 Fluf22 merged commit 536a348 into main Jun 25, 2024
13 checks passed
@Fluf22 Fluf22 deleted the fix/chunked-batch-size branch June 25, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fluf22 @algolia-bot @shortcuts