Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): mention main branch instead of master #3566

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 20, 2024

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

closes algolia/algoliasearch-client-csharp#858, also fixes the Go client that targets the master branch

@shortcuts shortcuts self-assigned this Aug 20, 2024
@shortcuts shortcuts requested a review from a team as a code owner August 20, 2024 14:29
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 20, 2024

✔️ Code generated!

Name Link
🪓 Triggered by db07e2216253ae1ee694e49d9ba33eb30ae3c2ea
🍃 Generated commit faa1614c67d9037387b9ac65f345664797b277a6
🌲 Generated branch generated/fix/csharp-changelog
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
php 1326
javascript 1265
csharp 1001
java 919
ruby 914
swift 739
python 729
kotlin 463
go 426

@shortcuts shortcuts changed the title fix(csharp): changelog location fix(clients): mention main branch instead of master Aug 20, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix go in README.md pls too ? and kotlin README.md

@shortcuts
Copy link
Member Author

can you fix go in README.md pls too ? and kotlin README.md

kotlin requires a bit more work looks like it's totally outdated

millotp
millotp previously approved these changes Aug 20, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay too bad

@shortcuts
Copy link
Member Author

okay too bad

actually I'll do it and STOP BEING LAZY brb

Copy link

github-actions bot commented Aug 20, 2024

@shortcuts
Copy link
Member Author

I've also updated the new links to the doc

@shortcuts shortcuts requested a review from millotp August 20, 2024 14:43
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge !

templates/kotlin/README.mustache Outdated Show resolved Hide resolved
@shortcuts shortcuts requested a review from millotp August 20, 2024 14:46
@shortcuts shortcuts enabled auto-merge (squash) August 20, 2024 15:14
@shortcuts shortcuts merged commit 9dedfc9 into main Aug 20, 2024
20 checks passed
@shortcuts shortcuts deleted the fix/csharp-changelog branch August 20, 2024 15:17
algolia-bot added a commit that referenced this pull request Aug 20, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3566

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3566

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3566

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3566

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3566

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3566

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3566

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3566

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3566

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3566

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad changelog from NuGet
3 participants