chore: fix specs run condition #488
Conversation
shortcuts
requested review from
eunjae-lee and
millotp
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
.github/actions/setup/action.yml
Outdated
| @@ -135,12 +135,12 @@ outputs: | |||
| RUN_CTS: | |||
| description: Determine if the `cts` jobs should run | |||
| value: ${{ | |||
| steps.spec-matrix.outputs.RUN_SPECS || | |||
There was a problem hiding this comment.
Where is RUN_SPECS defined ?
There was a problem hiding this comment.
In the specs matrix step Compute specs matrix
There was a problem hiding this comment.
ok so it's always true, I think you can remove it
There was a problem hiding this comment.
you don't want to remove it ?
There was a problem hiding this comment.
Ah I thought you were talking about the RUN_CTS, which would always be true
There was a problem hiding this comment.
do you see anything else to remove here? 4a529f5
There was a problem hiding this comment.
RUN_CTS is always true now also, we lost the ability to run just the CTS without generation the client but's that's fine, it's fast
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
As observed in #487, the specs are not running while changes are definitely here.
This PR fixes the run conditions of the
specsandclientsjobs:runoutput set per languageJS_variables to match actual language nameMATRIX_DEPENDENCIESdefinition to make it more dynamic🧪 Test
CI :D