-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare release 2022-05-25 #555
Conversation
❌ Deploy Preview for api-clients-automation failed.
|
(testing to see if it generates properly) |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Netlify should obviously fail as the clients are not updated, but should succeed on main 🤔 We should skip the build on release |
We cannot choose what to release anymore ? It's all or nothing ? |
We can update the PR changes but for now there's no automated way, it should be at the CLI level IMO |
Ah |
I thought this was at least synced between you two. |
We have control on the PR changes, so if there is none, there will be no release anyway. Once I'm sure it works I'll make it configurable from the CLI wdyt? |
What I meant by "sync", is sharing this context with Pierre before jumping into the work. |
I reviewed the PR but I didn't pay enough attention, I'm fine with this change being in the cli |
Yes but it's not as if there was no way to prevent all clients to release, there's an alternative |
Summary
This PR has been created using the
yarn release
script. Once merged, the clients will try to release their new version if their version has changed.Version Changes
minor
(e.g. 0.4.0)minor
(e.g. 0.1.0)minor
(e.g. 0.1.0)Skipped Commits
It doesn't mean these commits are being excluded from the release. It means they're not taken into account when the release process figured out the next version number, and updated the changelog.
Commits without language scope:
Commits with unknown language scope:
specs
commits for versioning (feat(scripts): considerspecs
commits for versioning #523)utilsPackageVersion
for JavaScript (feat(generators): factorutilsPackageVersion
for JavaScript #511)requestOptions
follow same format (fix(templates): ensurerequestOptions
follow same format #506)