Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare release 2022-05-25 #555

Closed
wants to merge 1 commit into from

Conversation

shortcuts
Copy link
Member

Summary

This PR has been created using the yarn release script. Once merged, the clients will try to release their new version if their version has changed.

Version Changes

  • javascript: 0.3.0 -> minor (e.g. 0.4.0)
  • java: 0.0.1 -> minor (e.g. 0.1.0)
  • php: 0.0.1 -> minor (e.g. 0.1.0)

Skipped Commits

It doesn't mean these commits are being excluded from the release. It means they're not taken into account when the release process figured out the next version number, and updated the changelog.

Commits without language scope:
Commits with unknown language scope:

@shortcuts shortcuts requested review from a team, eunjae-lee and millotp and removed request for a team May 25, 2022 12:38
@netlify
Copy link

netlify bot commented May 25, 2022

Deploy Preview for api-clients-automation failed.

Name Link
🔨 Latest commit 020fa2b
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/628e2346a400fc0009e8cf17

@shortcuts shortcuts self-assigned this May 25, 2022
@shortcuts
Copy link
Member Author

(testing to see if it generates properly)

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 25, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts
Copy link
Member Author

shortcuts commented May 25, 2022

Netlify should obviously fail as the clients are not updated, but should succeed on main 🤔

We should skip the build on release

@millotp
Copy link
Collaborator

millotp commented May 25, 2022

We cannot choose what to release anymore ? It's all or nothing ?

@shortcuts
Copy link
Member Author

shortcuts commented May 25, 2022

We cannot choose what to release anymore ? It's all or nothing ?

We can update the PR changes but for now there's no automated way, it should be at the CLI level IMO

@shortcuts
Copy link
Member Author

Ah codegen should wait for algoliasearch otherwise we miss those changes

@eunjae-lee
Copy link
Contributor

We cannot choose what to release anymore ? It's all or nothing ?

I thought this was at least synced between you two.

@shortcuts
Copy link
Member Author

We cannot choose what to release anymore ? It's all or nothing ?

I thought this was at least synced between you two.

We have control on the PR changes, so if there is none, there will be no release anyway.

Once I'm sure it works I'll make it configurable from the CLI wdyt?

@shortcuts shortcuts closed this May 25, 2022
@shortcuts shortcuts deleted the chore/prepare-release-2022-05-25 branch May 25, 2022 13:16
@eunjae-lee
Copy link
Contributor

What I meant by "sync", is sharing this context with Pierre before jumping into the work.

@millotp
Copy link
Collaborator

millotp commented May 25, 2022

I reviewed the PR but I didn't pay enough attention, I'm fine with this change being in the cli

@shortcuts
Copy link
Member Author

What I meant by "sync", is sharing this context with Pierre before jumping into the work.

Yes but it's not as if there was no way to prevent all clients to release, there's an alternative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants