-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(templates): make queryParameters
naming consistent
#494
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
8483b34
to
7a9bb05
Compare
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
@@ -16,4 +16,4 @@ jobs: | |||
- name: Pull Request title rules | |||
uses: deepakputhraya/action-pr-title@v1.0.2 | |||
with: | |||
regex: '^(docs|chore)|((?:feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)\((?:generator|javascript|php|java|cts|spec|script|ci)\)): .+' | |||
regex: '^(docs|chore)|((?:feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)\((?:generators|javascript|php|java|cts|specs|scripts|ci|templates)\)): .+' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
folder files etc are all using plural form so it's reflected here too
What do we do now that it's a tie ? :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is not a big deal, let's not waste time and go for queryParameters
👍 🚀
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
While implementing the CTS for the
requestOptions
I realized we re-introduced inconsistency in the naming.edit: Draft until we know if we go with
queryParams
orqueryParameters
edit2:
queryParameters
won the polledit3: it's a tie again
edit4: team
queryParams
forfeit🧪 Test
CI :D