Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(javascript): cache on POST read request #611

Merged
merged 1 commit into from
May 31, 2022
Merged

fix(javascript): cache on POST read request #611

merged 1 commit into from
May 31, 2022

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented May 31, 2022 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: /

Changes included:

  • allows a "read post request" to be cached too

🧪 Test

Do multiple identical search requests (this doesn't work yet until #612, as it's not set as cacheable: true, setting up a separate PR for that)

@Haroenv Haroenv requested review from millotp and shortcuts May 31, 2022 08:54
@netlify
Copy link

netlify bot commented May 31, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 837a470
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6295d7c60fb1b40008841641

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 31, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Haroenv Haroenv mentioned this pull request May 31, 2022
Merged
@Haroenv Haroenv marked this pull request as ready for review May 31, 2022 09:17
@Haroenv Haroenv requested a review from bodinsamuel May 31, 2022 09:18
millotp
millotp approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sound, thanks !

@millotp millotp merged commit d62318b into main May 31, 2022
@millotp millotp deleted the fix/cache-on-get branch May 31, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@shortcuts shortcuts Awaiting requested review from shortcuts

@bodinsamuel bodinsamuel Awaiting requested review from bodinsamuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Haroenv @algolia-bot @millotp