-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(javascript): enable cache #612
Conversation
cacheable is already a key in the transporter's Request interface, but no method actually set it before now
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So fast ! thank you !
What do you use to determine if a requests is cacheable or not ? Do we have a list somewhere ?
I used the same list as the ones that have "useReadTransporter", which are all POST. Not sure if the other GET ones should be cached as well, you can compare with v4 here: https://github.com/algolia/algoliasearch-client-javascript/search?q=cacheable%3A+true |
I'd say it's only urgent for the requests commonly used frontend (search, recommend) |
🧭 What and Why
cacheable is already a key in the transporter's Request interface, but no method actually set it before now
🎟 JIRA Ticket: APIC-503
Changes included:
🧪 Test
search no longer does two requests if you do it twice (in combination with #611