Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript): provide browseObjects, browseRules and browseSynonyms helper methods #887

Merged
merged 4 commits into from
Aug 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/.cache_version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.0.11
0.0.12
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"files": [
{
"path": "packages/algoliasearch/dist/algoliasearch.umd.js",
"maxSize": "8.30KB"
"maxSize": "8.60KB"
},
{
"path": "packages/algoliasearch/dist/lite/lite.umd.js",
Expand Down Expand Up @@ -30,7 +30,7 @@
},
{
"path": "packages/client-search/dist/client-search.umd.js",
"maxSize": "6.60KB"
"maxSize": "6.90KB"
},
{
"path": "packages/client-sources/dist/client-sources.umd.js",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export * from './src/createAuth';
export * from './src/createEchoRequester';
export * from './src/createRetryablePromise';
export * from './src/createIterablePromise';
export * from './src/cache';
export * from './src/transporter';
export * from './src/createAlgoliaAgent';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const config: Config.InitialOptions = {
testPathIgnorePatterns: [
'src/__tests__/cache/null-cache.test.ts',
'src/__tests__/cache/memory-cache.test.ts',
'src/__tests__/create-iterable-promise.test.ts',
],
},
{
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,238 @@
import { createIterablePromise } from '../createIterablePromise';

describe('createIterablePromise', () => {
describe('func', () => {
it('provides the `previousResponse` parameter', async () => {
const responses: Array<string | undefined> = [];
const promise = createIterablePromise<string | undefined>({
func: (previousResponse) => {
return new Promise((resolve) => {
resolve(previousResponse === undefined ? 'yes' : 'no');
});
},
validate: () => responses.length === 3,
aggregator: (response) => responses.push(response),
});

await expect(promise).resolves.toEqual('no');
expect(responses).toEqual(['yes', 'no', 'no']);
});
});

describe('validate', () => {
it('iterates on a `func` until `validate` is met', async () => {
let calls = 0;
const promise = createIterablePromise({
func: () => {
return new Promise((resolve) => {
calls += 1;
resolve(`success #${calls}`);
});
},
validate: () => calls >= 3,
});

await expect(promise).resolves.toEqual('success #3');
expect(calls).toBe(3);
});

it('forward the response of the `func`', async () => {
let calls = 0;
const promise = createIterablePromise<number>({
func: () => {
return new Promise((resolve) => {
calls += 1;
resolve(calls);
});
},
validate: (response) => response >= 3,
});

await expect(promise).resolves.toEqual(3);
expect(calls).toBe(3);
});
});

describe('aggregator', () => {
it('is called before iterating', async () => {
let calls = 0;
let count = 0;
const promise = createIterablePromise({
func: () => {
return new Promise((resolve) => {
calls += 1;
resolve(`success #${calls}`);
});
},
validate: () => calls >= 3,
aggregator: () => (count += 3),
});

await expect(promise).resolves.toEqual('success #3');
expect(calls).toBe(3);
expect(count).toBe(3 * 3);
});

it('forward the response of the `func`', async () => {
let calls = 0;
const responses: string[] = [];
const promise = createIterablePromise<string>({
func: () => {
return new Promise((resolve) => {
calls += 1;
resolve(`success #${calls}`);
});
},
validate: () => calls >= 3,
aggregator: (response) => {
responses.push(response);
},
});

await expect(promise).resolves.toEqual('success #3');
expect(calls).toBe(3);
expect(responses).toEqual(['success #1', 'success #2', 'success #3']);
});
});

describe('timeout', () => {
it('defaults to no timeout (0)', async () => {
let calls = 0;
const before = Date.now();
const promise = createIterablePromise({
func: () => {
return new Promise((resolve) => {
calls += 1;
resolve(`success #${calls}`);
});
},
validate: () => calls >= 2,
});

await expect(promise).resolves.toEqual('success #2');

expect(Date.now() - before).toBeGreaterThanOrEqual(0);
expect(Date.now() - before).toBeLessThan(10);
expect(calls).toBe(2);
});

it('waits before calling the `func` again', async () => {
let calls = 0;
const before = Date.now();
const promise = createIterablePromise({
func: () => {
return new Promise((resolve) => {
calls += 1;
resolve(`success #${calls}`);
});
},
validate: () => calls >= 2,
timeout: () => 2000,
});

await expect(promise).resolves.toEqual('success #2');

expect(Date.now() - before).toBeGreaterThanOrEqual(2000);
expect(Date.now() - before).toBeLessThan(2010);
expect(calls).toBe(2);
});
});

describe('error', () => {
it('gets the rejection of the given promise via reject', async () => {
let calls = 0;

const promise = createIterablePromise({
func: () => {
return new Promise((resolve, reject) => {
calls += 1;
if (calls <= 3) {
resolve('okay');
} else {
reject(new Error('nope'));
}
});
},
validate: () => false,
});

await expect(promise).rejects.toEqual(
expect.objectContaining({ message: 'nope' })
);
});

it('gets the rejection of the given promise via throw', async () => {
let calls = 0;

const promise = createIterablePromise({
func: () => {
return new Promise((resolve) => {
calls += 1;
if (calls <= 3) {
resolve('okay');
} else {
throw new Error('nope');
}
});
},
validate: () => false,
});

await expect(promise).rejects.toEqual(
expect.objectContaining({ message: 'nope' })
);
});

it('rejects with the given `message` when `validate` hits', async () => {
const MAX_RETRIES = 3;
let calls = 0;

const promise = createIterablePromise({
func: () => {
return new Promise((resolve) => {
calls += 1;
resolve('okay');
});
},
validate: () => false,
error: {
validate: () => calls >= MAX_RETRIES,
message: () => `Error is thrown: ${calls}/${MAX_RETRIES}`,
},
});

await expect(promise).rejects.toEqual(
expect.objectContaining({
message: 'Error is thrown: 3/3',
})
);
expect(calls).toBe(MAX_RETRIES);
});

it('forward the response of the `func`', async () => {
const MAX_RETRIES = 3;
let calls = 0;

const promise = createIterablePromise<number>({
func: () => {
return new Promise((resolve) => {
calls += 1;
resolve(calls);
});
},
validate: () => false,
error: {
validate: (response) => response >= MAX_RETRIES,
message: (response) => `Error is thrown: ${response}/${MAX_RETRIES}`,
},
});

await expect(promise).rejects.toEqual(
expect.objectContaining({
message: 'Error is thrown: 3/3',
})
);
expect(calls).toBe(MAX_RETRIES);
});
});
});

This file was deleted.

Loading