feat(autocomplete-core): add enterKeyHint
option to manually set hint on virtual keyboards
#1164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we dynamically set the
enterKeyHint
property of the Autocomplete input, depending on whether there are results in collections and the items inside have URLs.This can cause issues in multiple situations we don't have control over, one we have identified being customers using the Samsung keyboard on Android and have predictive input enabled.
We have a guard in place that works by identifying the type of device, but latest developments with the Android Chrome browser prevents retrieving the data we need, so we are less and less able to correctly activate this guard.
For customers who want to address this issue, and to keep accessibility benefit for others, this PR introduces an
enterKeyHint
prop on Autocomplete, that when defined, will take precedence over the current heuristics, and statically set the value on the Autocomplete input.