Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): use theme package from monorepo #1177

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Aug 10, 2023

Summary

Currently examples retrieve a version of @algolia/autocomplete-theme-classic that is not up to date, which makes yarn retrieve it from npm instead of linking it from the monorepo. This PR fixes this.

@dhayab dhayab requested review from a team, sarahdayan and aymeric-giraudet and removed request for a team August 10, 2023 08:28
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f770182:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the yarn.lock not also have been edited?

@dhayab
Copy link
Member Author

dhayab commented Aug 10, 2023

should the yarn.lock not also have been edited?

@Haroenv the lockfile was not versioned correctly. A yarn install on the repo revealed this issue to me, as yarn.lock got modified after the operation.

So this change reverts the lockfile to its expected state (not referencing the theme package from npm).

@Haroenv
Copy link
Contributor

Haroenv commented Aug 10, 2023

@dhayab, yes, but why is there no change in yarn.lock in this commit then?

@dhayab
Copy link
Member Author

dhayab commented Aug 10, 2023

@Haroenv

Because the only diff in yarn.lock was

+"@algolia/autocomplete-theme-classic@1.9.4":
+  version "1.9.4"
+  resolved "https://registry.yarnpkg.com/@algolia/autocomplete-theme-classic/-/autocomplete-theme-classic-1.9.4.tgz#6400359de17fe0c698eb65303f67cea53175bb08"
+  integrity sha512-ydeYji3VKIPRFHTnIBVbwocFs9FOKLJnQtYIqmT3z3SVhsceeju2XUD9v3jZRrKb9FVrs1oKQaw0MsessZXMkw==

If with this PR I remove all mentions of autocomplete-theme-classic@1.9.4, this reference disappears, making it equivalent to the yarn.lock currently versioned.

@dhayab dhayab merged commit 207d41a into next Aug 10, 2023
9 checks passed
@dhayab dhayab deleted the chore/sync-theme-package-version branch August 10, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants