Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): prevent conflict between recently viewed items and searches plugins #1178

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Aug 10, 2023

Summary

CR-4071 has found an issue with autocomplete when a customer adds both the recent searches plugin and the userland recently viewed items plugin we provide as an example. This is because the last is based on the first, and both share the same plugin name and source id.

This PR makes sure the userland code we provide for the recently viewed items plugin sets its own source id and plugin name.

@dhayab dhayab requested review from a team, sarahdayan and aymeric-giraudet and removed request for a team August 10, 2023 10:19
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c72dd7:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🅰️h, I didn't realise that the source id would have this effect

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to approve

@dhayab dhayab enabled auto-merge (squash) August 11, 2023 08:33
@dhayab dhayab merged commit f341055 into next Aug 11, 2023
9 checks passed
@dhayab dhayab deleted the examples/fix-recently-viewed-items-conflict branch August 11, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants