Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behaviour): clear completion on "reset" #1215

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Oct 27, 2023

Summary

When reset is called when a completion is active, it should also be reset.

Review notes: 9f07965 is the main implementation, other commits will be rebased and came up through writing a test for it.

Result

  • improved tests
  • reset clears completion too
before.mov
after.mov

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 86e2d76:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

@Haroenv Haroenv marked this pull request as ready for review October 27, 2023 08:49
Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Haroenv Haroenv merged commit caa3ef8 into next Oct 27, 2023
9 checks passed
@Haroenv Haroenv deleted the fix/reset-completion branch October 27, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants