feat(insights): update default version to support authenticatedUserToken
#1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
requested review from
a team,
sarahdayan and
aymeric-giraudet
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit badacc1:
|
sarahdayan
reviewed
Dec 13, 2023
Comment on lines
315
to
317
| if (!userToken) { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
We're checking whether userToken is defined in l. 181 so we shouldn't have to check it again, right?
There was a problem hiding this comment.
You're right, thanks! I've updated the code.
aymeric-giraudet
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets updates the
search-insightsdependency and the version retrieved at runtime to the current latest. This gives the ability to setauthenticatedUserTokensubsequently without requiring users to manually load the library.