Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add keypress effect to DocSearchButton #2087

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat: add keypress effect to DocSearchButton #2087

merged 3 commits into from
Oct 5, 2023

Conversation

SevenOutman
Copy link
Contributor

Add this subtle effect that responds to keypress on Meta/Ctrl and K.

docsearch.mov
docsearch.mov

@netlify
Copy link

netlify bot commented Oct 1, 2023 •
edited
Loading

👷 Deploy request for docsearch pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 46de0f4

@8bittitan
Copy link
Contributor

Hi @SevenOutman this looks really good! Could you please run yarn test:size in your local and update the bundlesize.config.json accordingly for the CI to pass please? 😄

@SevenOutman
Copy link
Contributor Author

Hi @SevenOutman this looks really good! Could you please run yarn test:size in your local and update the bundlesize.config.json accordingly for the CI to pass please? 😄

Sure. Will do that after coming back from vacation.

@8bittitan
Copy link
Contributor

Hi @SevenOutman this looks really good! Could you please run yarn test:size in your local and update the bundlesize.config.json accordingly for the CI to pass please? 😄

Sure. Will do that after coming back from vacation.

Ah no worries then, I can take care of it for you! And merge this in after 😄

@SevenOutman
Copy link
Contributor Author

Ah no worries then, I can take care of it for you! And merge this in after 😄

That's so helpful. Thanks!

@8bittitan 8bittitan merged commit 4c82640 into algolia:main Oct 5, 2023
6 checks passed
@mohamed-samandi mohamed-samandi mentioned this pull request May 24, 2024
Closed
@OKEAMAH OKEAMAH mentioned this pull request May 27, 2024
Open
@redvlock redvlock mentioned this pull request May 31, 2024
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
@q1blue q1blue mentioned this pull request Jun 26, 2024
Open
@Summonshr Summonshr mentioned this pull request Jun 29, 2024
Open
This was referenced Jul 7, 2024
Open
Open
@Summonshr Summonshr mentioned this pull request Jul 13, 2024
Open
@shortcuts shortcuts mentioned this pull request Aug 5, 2024
Closed
7 tasks
@q1blue q1blue mentioned this pull request Aug 6, 2024
Open
This was referenced Aug 7, 2024
Open
Merged
@OKEAMAH OKEAMAH mentioned this pull request Sep 10, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 12, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8bittitan 8bittitan 8bittitan approved these changes

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner

@francoischalifour francoischalifour Awaiting requested review from francoischalifour francoischalifour is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SevenOutman @8bittitan