Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does nothing if inputSelector finds 2 or more tags #74

Closed
ElPicador opened this issue Feb 22, 2016 · 10 comments
Closed

Does nothing if inputSelector finds 2 or more tags #74

ElPicador opened this issue Feb 22, 2016 · 10 comments
Labels

Comments

@ElPicador
Copy link
Contributor

If there is in the page 2 or more selectors that matches inputSelector it does nothing.

@ElPicador ElPicador added the bug label Feb 22, 2016
@pixelastic
Copy link
Contributor

What would be the best behavior for you?

Code-wise, the easiest would be to enable docsearch only on the first one. The library does not react really well to multiple inputs.

@vvo
Copy link
Contributor

vvo commented Mar 10, 2016

We should throw so that we are explicit and the user can see he made a mistake.

@vvo
Copy link
Contributor

vvo commented Mar 10, 2016

If it's already failing then it's the easiest to throw explicit error?

@ElPicador
Copy link
Contributor Author

I would throw an error, but enable on the first one

@pixelastic
Copy link
Contributor

Ok, I'll have a look at that

@vvo
Copy link
Contributor

vvo commented Mar 10, 2016

I would really throw and explain to the user he made something bad. Fixing bugs for him will bite you :D

@pixelastic
Copy link
Contributor

@vvo @ElPicador I've submitted the PR here: #80

It will now throw an error if there is not exactly one input matching

@redox
Copy link
Contributor

redox commented Mar 10, 2016

For the record, that was a bug of autocomplete.js's standalone version (Zepto based): it has been fixed - not yet release - and you can now setup your dropdown menu on several search bars.

@pixelastic
Copy link
Contributor

So we can close this issue?

@redox
Copy link
Contributor

redox commented Mar 21, 2016

Once we've upgraded to autocomplete.js=0.17.2 only.

redox added a commit that referenced this issue Mar 21, 2016
This includes latest autocomplete.js to handle multiple inputs binding.

Ref #74 & #80
@redox redox closed this as completed Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants