fix(vue-instantsearch): properly add noRefinement
class on <ais-refinement-list>
#6095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the is searchable and a user searches for a facet value that doesn't exist, the root should have the class .ais-RefinementList--noRefinement. This was however not the case because we were relying on
canRefine
which remainstrue
as long as the last search contains search results.Now we're relying on the items returned from SFFV.
In the future, we may want to reconsider what
canRefine
means in the context ofconnectRefinementList
, as the source of refinements comes from two places (main search and SFFV), but this would be breaking right now so we can keep it for later.Note
This change doesn't update tests, because existing ones weren't testing this use case. This will be touched on in #6090.