New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instantsearch-ui-components): introduce `FrequentlyBoughtTogether` component #6114

Merged

sarahdayan merged 38 commits into feat/map-recommend-results from feat-recommend-fbt-ui-component

Apr 15, 2024

Contributor

raed667 commented Apr 3, 2024 •

edited by sarahdayan

Summary

This moves the FrequentlyBoughtTogether UI component from algolia/recommend to the monorepo.

https://algolia.atlassian.net/browse/FX-2793

dhayab and others added 11 commits

March 28, 2024 11:42


          chore: update algoliasearch version

440e9cc


          feat(helper): add methods to request and retrieve recommendations

81b4400


          add tests

0eac184


          emit placeholder change event and test events better

98018d8


          Merge branch 'master' into feat/helper-recommend-methods

84937b3


          bump bundle sizes

6f064f8


          Merge branch 'master' into feat/helper-recommend-methods

9469f26


          retrieve recommend queries on all index widgets through derived helpers

2cc4743


          add tests for derived helper

2a70204


          bump bundlesize

2518d91


          feat(recommend): add FBT to instantsearch-ui-components

7ab1436

raed667 added the Feature: Recommendations label


          fix: split component files to fix type errors

d326cab

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/FrequentlyBoughtTogether.tsx Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/DefaultHeader.tsx Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/ListView.tsx Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/types.ts Outdated Show resolved Hide resolved

raed667 added 3 commits

April 4, 2024 10:27


          fix babel spread issue

60f8c9c


          replace classes auc with ais

ab5dd33


          fix: address feedback

e8544c6

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/types/Recommend.ts Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/types/Recommend.ts Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/types/Recommend.ts Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/FrequentlyBoughtTogether.tsx Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/recommend-inner/DefaultHeader.tsx Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/recommend-inner/DefaultHeader.tsx Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/recommend-inner/DefaultHeader.tsx Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/__tests__/FrequentlyBoughtTogether.test.tsx Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/__tests__/FrequentlyBoughtTogether.test.tsx Outdated Show resolved Hide resolved

sarahdayan reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/__tests__/FrequentlyBoughtTogether.test.tsx Outdated Show resolved Hide resolved

packages/instantsearch-ui-components/src/components/__tests__/FrequentlyBoughtTogether.test.tsx Outdated Show resolved Hide resolved

packages/instantsearch-ui-components/src/components/__tests__/FrequentlyBoughtTogether.test.tsx Show resolved Hide resolved

sarahdayan added 2 commits

April 8, 2024 11:42


          fix: fix build

cb00cee


          fix: add __position

44b40fe

sarahdayan changed the title ~~feat(recommend): add FBT to instantsearch-ui-components~~ feat(instantsearch-ui-components): introduce FrequentlyBoughtTogether component

sarahdayan reviewed

View reviewed changes

packages/algoliasearch-helper/src/algoliasearch.helper.js Outdated Show resolved Hide resolved

sarahdayan marked this pull request as ready for review

April 8, 2024 13:05

sarahdayan requested review from a team, sarahdayan, aymeric-giraudet, dhayab and Haroenv and removed request for a team

April 8, 2024 13:05

dhayab reviewed

View reviewed changes

Member

dhayab left a comment

What I'm seeing looks good. Could we add the Insights-related stuff we worked on this morning? There are some props and types relevant to ui components.

packages/algoliasearch-helper/src/algoliasearch.helper.js Outdated Show resolved Hide resolved

packages/algoliasearch-helper/src/algoliasearch.helper.js Outdated Show resolved Hide resolved

raed667 and others added 3 commits

April 8, 2024 17:01


          Update packages/algoliasearch-helper/src/algoliasearch.helper.js

853d96a

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>


          add support and types for sendEvent

f9c44d2

Took the relevant parts from 8498792 and moved them into this PR.


          fix tests

4dbc64c

aymeric-giraudet reviewed

View reviewed changes

packages/instantsearch-ui-components/src/components/recommend-shared/ListView.tsx Outdated Show resolved Hide resolved

sarahdayan added 2 commits

April 9, 2024 18:15


          fix: fix issues with sendEvent and test it

a62a979


          fix: stop passing createElement and Fragment to ItemComponent

30d0f35

sarahdayan requested review from dhayab and aymeric-giraudet

April 9, 2024 16:16


          style: lint

087f1f3

dhayab approved these changes

View reviewed changes

Member

dhayab left a comment

LGTM 🚀


          feat: remove default click event

7dd719c

sarahdayan merged commit 5a7ed9e into feat/map-recommend-results

8 checks passed

sarahdayan deleted the feat-recommend-fbt-ui-component branch

April 15, 2024 13:15

dhayab mentioned this pull request

feat(recommend): introduce frequentlyBoughtTogether widget #6126

Merged

dhayab added a commit that referenced this pull request


          feat(instantsearch-ui-components): introduce `FrequentlyBoughtTogethe…

05a01e5

…r` component (#6114)

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>

Haroenv pushed a commit that referenced this pull request


          feat(instantsearch-ui-components): introduce `FrequentlyBoughtTogethe…

54db8b3

…r` component (#6114)

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>

dhayab added a commit that referenced this pull request


          feat(recommend): introduce FrequentlyBoughtTogether UI component (#…

ddde6d2

…6114)

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>

dhayab added a commit that referenced this pull request


          feat(recommend): introduce FrequentlyBoughtTogether UI component (#…

7d78f63

…6114)

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment