feat(recommend): introduce frequentlyBoughtTogether widget
#6126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
sarahdayan
requested changes
Apr 22, 2024
packages/instantsearch.js/src/widgets/frequently-bought-together/frequently-bought-together.tsx
Outdated
Show resolved
Hide resolved
...arch.js/src/widgets/frequently-bought-together/__tests__/frequently-bought-together.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
I'm wondering whether we should change a bit how we pass default templates, otherwise we'll have to duplicate them in every flavor although they should be the same.
Maybe each flavor shouldn't define default templates at all. Instead, we'd set them in the UI component and override them only when users pass them. WDYT?
There was a problem hiding this comment.
Definitely make sense to centralize component props at the ui-components level.
Not sure moving what we have as "templates" right now is worth it though. We'll remove templates altogether when we ditch Hogan, as we'll be able to rely on component props from ui-components directly.
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
dhayab
force-pushed
the
feat/recommend-fbt-widget
branch
from
722d966
to
f577aa9
Compare
Base automatically changed from
feat/recommend-fbt-connector
to
feat/map-recommend-results
April 23, 2024 07:56
aymeric-giraudet
approved these changes
Apr 23, 2024
Haroenv
pushed a commit
that referenced
this pull request
May 21, 2024
--------- Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
dhayab
added a commit
that referenced
this pull request
May 21, 2024
--------- Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
dhayab
added a commit
that referenced
this pull request
May 21, 2024
--------- Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the
frequentlyBoughtTogetherwidget for InstantSearch.js. It leverages the work done on #6114 for the ui component and #6117 for the connector, to create the built-in widget that users will be able to use.Notes
To make the widget feel native to InstantSearch, some changes have been made regarding props from the original standalone component:
itemComponentis now defined in theitemtemplateheaderComponentis now defined in theheadertemplatefallbackComponentis now defined in theemptytemplateviewis now defined in theviewtemplatetranslationsis foreign to InstantSearch.js, so I'm not in favor of introducing it with Recommend widgets:headertemplate can sub fortranslations.titlesliderLabelTexttemplate when we'll migrate the horizontal slider if necessaryFX-2795