feat(recommend): introduce connectRelatedProducts connector
#6142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
force-pushed
the
feat/map-recommend-results
branch
from
fa726da
to
3121f7a
Compare
dhayab
requested changes
Apr 22, 2024
There was a problem hiding this comment.
A few questions and changes on how to align both connectors PRs.
I like the outline of the connector common test suite. Are we confident with our "end-user" test suite and dropping more granular tests that might not be possible in CTS (like checking the number of renderings for example) ?
packages/instantsearch.js/src/connectors/related-products/connectRelatedProducts.ts
Show resolved
Hide resolved
packages/instantsearch.js/src/connectors/related-products/connectRelatedProducts.ts
Outdated
Show resolved
Hide resolved
packages/instantsearch.js/src/connectors/related-products/connectRelatedProducts.ts
Outdated
Show resolved
Hide resolved
Haroenv
approved these changes
Apr 22, 2024
packages/instantsearch.js/src/connectors/related-products/connectRelatedProducts.ts
Show resolved
Hide resolved
dhayab
approved these changes
Apr 22, 2024
Haroenv
pushed a commit
that referenced
this pull request
May 21, 2024
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
dhayab
added a commit
that referenced
this pull request
May 21, 2024
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
dhayab
added a commit
that referenced
this pull request
May 21, 2024
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
connectRelatedProductsconnector and tests it in the connector common test suite.https://algolia.atlassian.net/browse/FX-2813