Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(frequentlyBoughtTogether): move to common test suite #6152

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Apr 23, 2024

Summary

This is a followup to #6117 and it moves the connector tests to the common test suite, as introduced with #6142.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should keep some of the tests outside of the CTS, that are relevant to how InstantSearch itself relies on the connector to manage its lifecycle.

Copy link

codesandbox-ci bot commented Apr 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 54178ae:

Sandbox Source
react-instantsearch-app Configuration
example-react-instantsearch-default-theme Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-vue-instantsearch-default-theme Configuration

@dhayab dhayab merged commit b79c92a into feat/map-recommend-results Apr 23, 2024
8 checks passed
@dhayab dhayab deleted the test/recommend-fbt-connector-cts branch April 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants