-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instantsearch.js): introduce relatedProducts
widget
#6154
Merged
sarahdayan
merged 85 commits into
feat/map-recommend-results
from
feat/recommend-rp-widget
Apr 26, 2024
Merged
feat(instantsearch.js): introduce relatedProducts
widget
#6154
sarahdayan
merged 85 commits into
feat/map-recommend-results
from
feat/recommend-rp-widget
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
added
the
Feature: Recommendations
Providing recommendations of records or facets
label
Apr 24, 2024
sarahdayan
changed the title
feat(recommend): introduce
feat(instantsearch.js): introduce Apr 25, 2024
relatedProducts
widgetrelatedProducts
widget
packages/instantsearch.js/src/widgets/related-products/related-products.tsx
Outdated
Show resolved
Hide resolved
aymeric-giraudet
approved these changes
Apr 25, 2024
dhayab
requested changes
Apr 25, 2024
packages/instantsearch.js/src/widgets/related-products/related-products.tsx
Show resolved
Hide resolved
packages/instantsearch.js/src/widgets/related-products/related-products.tsx
Show resolved
Hide resolved
dhayab
approved these changes
Apr 26, 2024
Haroenv
pushed a commit
that referenced
this pull request
May 21, 2024
dhayab
pushed a commit
that referenced
this pull request
May 21, 2024
dhayab
pushed a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
relatedProducts
widget and tests it in the widget common test suite.This PR changes a few things in how we pass templates to the UI component:
The
<RelatedProducts>
UI component now defines all default templates. This lets us define them once for all flavors instead of passing them manually and risking output drifts.InstantSearch.js doesn't pass default templates in
relatedProducts
since they're defined in the UI component.All
relatedProducts
templates are passed asFragment
s so we can avoid redefining components in the widget.https://algolia.atlassian.net/browse/FX-2814
https://algolia.atlassian.net/browse/FX-2815