Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recommend): harmonize UI component for FBT and Related Products #6157

Merged

Conversation

sarahdayan
Copy link
Member

This harmonizes the UI components for FBT and Related Products. This PR is necessary for #6154 to pass.

Copy link

codesandbox-ci bot commented Apr 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 18fa4f5:

Sandbox Source
react-instantsearch-app Configuration
example-react-instantsearch-default-theme Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-vue-instantsearch-default-theme Configuration

@sarahdayan sarahdayan added the Feature: Recommendations Providing recommendations of records or facets label Apr 25, 2024
Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just have a nitpick suggestion in the test for the FBT UI component.

@sarahdayan sarahdayan merged commit 439dc84 into feat/map-recommend-results Apr 25, 2024
8 checks passed
@sarahdayan sarahdayan deleted the feat/recommend-fbt-harmonization branch April 25, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Recommendations Providing recommendations of records or facets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants