feat(react-instantsearch-hooks web): rename <Stats> translation
#5756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahdayan
requested review from
a team,
dhayab,
aymeric-giraudet and
Haroenv
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f3e81ef:
|
|
It could also be added to the specs there : https://github.com/algolia/instantsearch/blob/master/specs/src/pages/widgets/stats.md Just something like : translations:
- name: rootElementText
default: ...
description: ... |
dhayab
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Thanks for fixing this!
I'm wondering, as it's breaking for current users of the widget, it might be safer to keep translations.stats as a fallback and, if its presence is detected:
- display a deprecation warning on console
- reassign to
translations.rootElementText
Wdyt?
Haroenv
requested changes
Jul 17, 2023
Haroenv
approved these changes
Jul 17, 2023
Haroenv
requested changes
Jul 17, 2023
dhayab
approved these changes
Jul 17, 2023
aymeric-giraudet
approved these changes
Jul 17, 2023
Haroenv
reviewed
Jul 17, 2023
packages/react-instantsearch-hooks-web/src/widgets/__tests__/Stats.test.tsx
Outdated
Show resolved
Hide resolved
Haroenv
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<Stats>widget was introduced in #5427 but the translation name isn't consistent with the convention we agreed on in the Translations RFC.This changes the name for something more consistent and conventional.
The change is breaking for anyone already using the
<Stats>widget.