fix(cache-hydration): normalize params returned from response #5946
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3a3c579:
|
| @@ -1,4 +1,6 @@ | |||
| // @ts-nocheck (types to be fixed during actual implementation) | |||
| params: request.params, | ||
| results[key].rawResults.map((result) => ({ | ||
| indexName: result.index, | ||
| params: serializeQueryParameters(qs.parse(result.params)), |
There was a problem hiding this comment.
it might or might not be right, but in v3 this is how the cache key is computed, also from the parameters, not from the result:
| function deserializeQueryParameters(parameters: string) { | ||
| return parameters.split('&').reduce<Record<string, any>>((acc, parameter) => { | ||
| const [key, value] = parameter.split('='); | ||
| acc[key] = value ? decodeURIComponent(value) : ''; |
There was a problem hiding this comment.
don't think it's worth deviating from the design, but instead of decode/encode uri component, we could simplify it and leave params uri encoded
There was a problem hiding this comment.
Actually I can't as it's also used in the mocked client.search which has decoded params, or I'd have to put a boolean argument in serializeQueryParameters like shouldEncode. Don't know if it's worth it.
Summary
There are discrepancies between how different versions of the search engine serialize query parameters.
This makes it so this caching solution does not work with all engines.
Result
We can normalize the params returned from the request so that it matches the same format as the one used by the search client.