feat(recommend): setup common test suite for frequentlyBoughtTogether
#6143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
dhayab
force-pushed
the
feat/recommend-fbt-widget
branch
from
722d966
to
f577aa9
Compare
dhayab
force-pushed
the
feat/recommend-fbt-cts
branch
from
b1721ea
to
fde10a7
Compare
Base automatically changed from
feat/recommend-fbt-widget
to
feat/map-recommend-results
April 23, 2024 11:58
sarahdayan
reviewed
Apr 24, 2024
...arch.js/src/widgets/frequently-bought-together/__tests__/frequently-bought-together.test.tsx
Outdated
Show resolved
Hide resolved
...arch.js/src/widgets/frequently-bought-together/__tests__/frequently-bought-together.test.tsx
Outdated
Show resolved
Hide resolved
...arch.js/src/widgets/frequently-bought-together/__tests__/frequently-bought-together.test.tsx
Outdated
Show resolved
Hide resolved
sarahdayan
approved these changes
Apr 24, 2024
...arch.js/src/widgets/frequently-bought-together/__tests__/frequently-bought-together.test.tsx
Outdated
Show resolved
Hide resolved
…er/__tests__/frequently-bought-together.test.tsx Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Haroenv
pushed a commit
that referenced
this pull request
May 21, 2024
…r` (#6143) --------- Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
dhayab
added a commit
that referenced
this pull request
May 21, 2024
--------- Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
dhayab
added a commit
that referenced
this pull request
May 21, 2024
--------- Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds tests for the
frequentlyBoughtTogetherwidget in the common test suite. Only implemented in InstantSearch.js for now, as the widget hasn't been implemented in React and there won't be initially Vue widgets for Recommend.This CTS also tests templates, which is a first, as before templates were highly flavor-specific. Because we now have a unified UI component, it is much easier. Still, I've opted to create the templates in the flavored implementation of the test suite due to the differences between templates / component props.