fix(index): allow dispose to be called before init #6173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If init isn't called (this happens in React InstantSearch Next, as well as some other cases), then dispose on the actual widgets doesn't make sense to be called, because the
helper
is still null.This does mean that some state could be considered stray (not cleaned up), but that likely doesn't matter as the index widget is removed anyway.
Result
fixes #6073