-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(recommend): enable multiple objectIDs in connectors #6176
feat(recommend): enable multiple objectIDs in connectors #6176
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 04f19f0:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look logical, but unit tests fail, so this can't be merged yet. Seems to happen inside the render function, maybe the "no results" case is trying to map as well?
@Haroenv |
* feat(recommend): enable multiple objectIDs in connectors * fix: merged recommendations should be in an object
* feat(recommend): enable multiple objectIDs in connectors * fix: merged recommendations should be in an object
* feat(recommend): enable multiple objectIDs in connectors * fix: merged recommendations should be in an object
Summary
FX-2822
Result
Following the previous PR, this enables the connectors to pass multiple object IDs