feat(recommend): introduce TrendingItems #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
added
the
Feature: Recommendations
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0adfb50:
|
Haroenv
force-pushed
the
feat/recommend-ti-react-widget
branch
from
534e470
to
1e539fb
Compare
dhayab
approved these changes
May 3, 2024
packages/react-instantsearch/src/widgets/__tests__/all-widgets.test.tsx
Outdated
Show resolved
Hide resolved
Haroenv
added a commit
that referenced
this pull request
May 21, 2024
* feat(recommend): introduce TrendingItems FX-2853 * fix(recommend): correct type for generic base Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> --------- Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
dhayab
added a commit
that referenced
this pull request
May 21, 2024
* feat(recommend): introduce TrendingItems FX-2853 * fix(recommend): correct type for generic base Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> --------- Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
dhayab
added a commit
that referenced
this pull request
May 21, 2024
* feat(recommend): introduce TrendingItems FX-2853 * fix(recommend): correct type for generic base Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> --------- Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the TrendingItems React widget and its related tests. Note that the tests have the same complexity on the type as is the case in vanilla; as the facet props can only be used if they're both set, but manipulating the props as a whole loses that relation.
Result
FX-2853