Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): update jsDelivrHitsEndpoint url #1074

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

MartinKolarik
Copy link
Collaborator

The current URL uses an undocumented feature we'll have to remove soon due to path conflicts with some new endpoints. To avoid any disruption here, this PR switches to a new URL on our preview environment.

Once we ship all changes to the production env (and this new endpoint is added and the old one removed), I'll send another PR to switch from data-jsdelivr-com-preview.onrender.com to data.jsdelivr.com

@MartinKolarik
Copy link
Collaborator Author

This change also makes the memory footprint of the response about 20x smaller by excluding packages with very few hits (< 100 / month) on the server, as they are being filtered out here anyway.

@MartinKolarik
Copy link
Collaborator Author

Ping 😄

@Haroenv
Copy link
Collaborator

Haroenv commented Nov 9, 2022

Sorry, I lost access to merge on this repository and haven't yet received a response from security. Will update

@Haroenv
Copy link
Collaborator

Haroenv commented Nov 22, 2022

Ok I have access again 🙌 Should this PR still be merged now @MartinKolarik ?

@MartinKolarik
Copy link
Collaborator Author

Yes please, we still need to migrate this in two steps as described above.

@Haroenv Haroenv merged commit 6213f95 into algolia:master Nov 22, 2022
@Haroenv
Copy link
Collaborator

Haroenv commented Nov 24, 2022

@MartinKolarik it looks like the test fails and jsDelivrHits is significantly lower than expected for some packages. Do you think that's expected?

@MartinKolarik
Copy link
Collaborator Author

Hmm what tests exactly?

@MartinKolarik
Copy link
Collaborator Author

Oh, I see. That's the number of packages in the response. That's affected by this:

This change also makes the memory footprint of the response about 20x smaller by excluding packages with very few hits (< 100 / month) on the server, as they are being filtered out here anyway.

So yes, it's expected the number is much lower now, I didn't realize there was a test for it.

@Haroenv
Copy link
Collaborator

Haroenv commented Nov 24, 2022

Thanks, I've updated it in d99c31f

algolia-crawler-bot pushed a commit that referenced this pull request Dec 7, 2022
## [1.7.14](v1.7.13...v1.7.14) (2022-12-07)

### Bug Fixes

* **config:** update jsDelivrHitsEndpoint url ([#1074](#1074)) ([6213f95](6213f95))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants