Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not minify due to stringify-object dependency not targeting browsers #285

Closed
jonthomp opened this issue Apr 27, 2018 · 6 comments
Closed

Can not minify due to stringify-object dependency not targeting browsers #285

jonthomp opened this issue Apr 27, 2018 · 6 comments

Comments

@jonthomp
Copy link

jonthomp commented Apr 27, 2018 •
edited
Loading

I'm trying to use this within a create-react-app project but am hitting build issues due to the dependency on stringify-object.

The issue is that they don't provide an ES5 compiled version and are apparently not willing to do so.

Any chance of changing to an alternative dependency or just building in a compiled version of stringify-object rather than relying on the dependency?
@jonthomp
Copy link
Author

jonthomp commented Apr 27, 2018 •
edited
Loading

I presume that #242 resolves the issue so will try that

@danoc
Copy link
Contributor

danoc commented May 25, 2018

@jonthomp — Any luck? The latest version (14.0.0) doesn't seem to work with the older version of Uglify I'm using through Gatsby.

@danoc
Copy link
Contributor

danoc commented May 25, 2018

I believe this is also related to: #211

@vvo
Copy link
Contributor

vvo commented May 26, 2018

@DanielHoffmann Can you use a more recent version of Uglify with Gatsby?

@danoc danoc mentioned this issue May 26, 2018
Merged
armandabric pushed a commit that referenced this issue Jun 4, 2018
@danoc @armandabric
fix(browser): Add IE 11 support (#288)
6c071b6 
This adds IE 11 support as well as support for older versions of Uglify.

It does so by transpiling `stringify-object` with babel.

Closes #211, #285
@pascalduez
Copy link
Contributor

Fixed in #288 and #292

@danoc
Copy link
Contributor

danoc commented Jun 22, 2018 •
edited
Loading

Can also confirm that this now works with older versions of Uglify.

@vvo vvo closed this as completed Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vvo @pascalduez @jonthomp @danoc